D3669: cmdutil: have statefile names in STATES instead of functions

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sun Jun 3 08:08:10 EDT 2018


pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in cmdutil.py:3210
> We don't have to. We could add a `clearstatefn` function in addition to the `statedetectionpredicate`. Perhaps the `if not clearable and ...` stuff could move into the function in that case

Don't you think it's getting a bit complicated?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3669

To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list