D2938: grep: make grep search on working directory by default

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Jun 6 10:11:32 EDT 2018


yuja added a comment.


  >   Hey @yuja 
  >   Can you explain why you did this ?
  >   
  >   > - slowpath = match.anypats() or (not match.always() and opts.get('removed')) +    slowpath = True
  
  From my vague memory, I guess I would think that if we do `s/ctx.files()/ctx/`
  (which means we're looking for revisions where files exist, not files change),
  the use of `walkfilerevs()` is not valid since filelogs only contain "changes."
  
  To be clear, I'm not saying that will be the desired behavior of `hg grep` of
  "--all-files" of multiple revisions. It might be better to skip intermediate
  revisions where files are unchanged.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2938

To: sangeet259, #hg-reviewers
Cc: av6, yuja, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list