D3699: run-tests: follow-up on the test-case format
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Jun 8 22:20:22 EDT 2018
yuja added a comment.
>> test-run-tests.t:1669
> > + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> > + +++ $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> > + @@ -1,3 +1,3 @@
>
> Windows can't create the test directory with all of the reserved characters here. Are these necessary?
Maybe no? I think alphanumerics + '-' should be enough, and allowing shell
meta characters is potentially unsafe.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3699
To: lothiraldan, #hg-reviewers, indygreg
Cc: yuja, mharbison72, mercurial-devel
More information about the Mercurial-devel
mailing list