D3699: run-tests: follow-up on the test-case format

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Tue Jun 12 16:45:16 EDT 2018


lothiraldan added a comment.


  In https://phab.mercurial-scm.org/D3699#58174, @yuja wrote:
  
  > >> test-run-tests.t:1669
  > >  > +  --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
  > >  > +  +++ $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
  > >  > +  @@ -1,3 +1,3 @@
  > > 
  > > Windows can't create the test directory with all of the reserved characters here.  Are these necessary?
  >
  > Maybe no? I think alphanumerics + '-' should be enough, and allowing shell
  >  meta characters is potentially unsafe.
  
  
  I checked core test files and some extensions test files. Alphanumerics + '-" would works for most of them. Some tests in the hg-experimental repository have a `.` in their test case name. I would also add `_` for allowing all naming cases. Does that sounds good?
  
  @mharbison72 I was not aware that this patch had been merged, is it breaking the windows build right now?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3699

To: lothiraldan, #hg-reviewers, indygreg
Cc: yuja, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list