D3439: templatefilters: add commonprefix
joerg.sonnenberger (Joerg Sonnenberger)
phabricator at mercurial-scm.org
Tue Jun 12 17:46:11 EDT 2018
joerg.sonnenberger added a comment.
In https://phab.mercurial-scm.org/D3439#58405, @martinvonz wrote:
> Do you think we should call it `commonpath()` or `commondir()` instead in case we want `commonprefix()` to work for any string in the future (and not care about path separators)?
`commondir()` would be fine as well. `commonpath()` doesn't feel better. I'm ambivalent about either name.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3439
To: joerg.sonnenberger, #hg-reviewers
Cc: martinvonz, yuja, mercurial-devel
More information about the Mercurial-devel
mailing list