D3728: grep: adds unmodified mode

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.


  In https://phab.mercurial-scm.org/D3728#58540, @yuja wrote:
  
  > >> commands.py:2411
  > >  >       _('only search files changed within revision range'), _('REV')),
  > >  > +    ('', 'unmodified', False,
  > >  > +     _('include all files in the changeset while grepping')),
  > > 
  > > I wonder if `--allfiles` is a better name.  `--unmodified` makes me think unmodified files exclusively.
  > > 
  > > It's too bad `--all` is already used, because that would be consistent with the all files meaning in `status` and `revert`.  (Maybe others?)  The plan page mentions BCing plain grep into oblivion, and deprecating `--all`.  Is it worth a BC on this too, for consistency going forward?
  >
  > Maybe we can keep all new flags hidden as "(EXPERIMENTAL)" until we make
  >  the final BC? I don't think it's time for bikeshedding yet.
  
  
  Agreed.  I haven't paid close attention to this, so I wasn't sure what was left.  But I wanted to flag it before I forgot.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3728

To: sangeet259, #hg-reviewers
Cc: pulkit, yuja, mharbison72, mercurial-devel