D3665: graph: improve graph output by using Unicode characters

[Sean Farley]

johnstiles (John Stiles) <phabricator at mercurial-scm.org> writes:

> johnstiles added a comment.
>
>
>   Hi there @indygreg and @yuja  -- are you happy with the diff as it currently stands? Do you think this needs any additional work?

Sorry for the late reply; was having email filtering issues (hopefully
fixed now).

Overall, I'm +0 on it because I think the "real" solution to this is to
templatize the graph glpyhs so any user could use whatever unicode they
desire. However, that's a tall order I wouldn't put on you so I'm fine
with putting this in and adding a note along the lines of, "the path to
get this in core is to get the graph log templated."

The only hiccup I keep having is the misalignment of graphs like these:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2018-06-14 at 4.00.50 PM.png
Type: image/png
Size: 6916 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2018-06-14 at 4.00.57 PM.png
Type: image/png
Size: 7420 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2018-06-14 at 4.01.25 PM.png
Type: image/png
Size: 6642 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2018-06-14 at 4.01.17 PM.png
Type: image/png
Size: 9301 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2018-06-14 at 4.01.03 PM.png
Type: image/png
Size: 6837 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment-0004.png>
-------------- next part --------------

Do you think there's any way to fix those? I suspect the answer is "no"
unless someone wants to write their own font?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/733c6ef6/attachment.sig>