D3665: graph: improve graph output by using Unicode characters
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Thu Jun 14 19:21:17 EDT 2018
spectral added a comment.
In https://phab.mercurial-scm.org/D3665#58616, @smf wrote:
> johnstiles (John Stiles) <phabricator at mercurial-scm.org> writes:
>
> > johnstiles added a comment.
> >
> > Hi there @indygreg and @yuja -- are you happy with the diff as it currently stands? Do you think this needs any additional work?
>
> Sorry for the late reply; was having email filtering issues (hopefully
> fixed now).
>
> Overall, I'm +0 on it because I think the "real" solution to this is to
> templatize the graph glpyhs so any user could use whatever unicode they
> desire. However, that's a tall order I wouldn't put on you so I'm fine
> with putting this in and adding a note along the lines of, "the path to
> get this in core is to get the graph log templated."
I had originally pushed for this to be templating or at least additional configuration for the graphlog, we currently have ways of changing the | and : markers via config (not template), but these don't support unicode because of https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/graphmod.py#l476, which is for this: https://www.mercurial-scm.org/repo/hg/file/tip/tests/test-glog.t#l3072
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3665
To: johnstiles, #hg-reviewers, spectral
Cc: spectral, indygreg, smf, yuja, mercurial-devel
More information about the Mercurial-devel
mailing list