D3745: commit: use context manager for locks
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jun 14 23:34:23 UTC 2018
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3745
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1523,13 +1523,8 @@
hg commit --amend --date now
"""
- wlock = lock = None
- try:
- wlock = repo.wlock()
- lock = repo.lock()
+ with repo.wlock(), repo.lock():
return _docommit(ui, repo, *pats, **opts)
- finally:
- release(lock, wlock)
def _docommit(ui, repo, *pats, **opts):
if opts.get(r'interactive'):
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list