D3728: grep: adds unmodified mode

Sean Farley sean at farley.io
Thu Jun 14 20:52:01 EDT 2018


Yuya Nishihara <yuya at tcha.org> writes:

>> > commands.py:2411
>> >       _('only search files changed within revision range'), _('REV')),
>> > +    ('', 'unmodified', False,
>> > +     _('include all files in the changeset while grepping')),
>> 
>> I wonder if `--allfiles` is a better name.  `--unmodified` makes me think unmodified files exclusively.
>> 
>> It's too bad `--all` is already used, because that would be consistent with the all files meaning in `status` and `revert`.  (Maybe others?)  The plan page mentions BCing plain grep into oblivion, and deprecating `--all`.  Is it worth a BC on this too, for consistency going forward?
>
> Maybe we can keep all new flags hidden as "(EXPERIMENTAL)" until we make
> the final BC? I don't think it's time for bikeshedding yet.

Yeah, that sounds like a good way forward to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/0005a48a/attachment.sig>


More information about the Mercurial-devel mailing list