D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Jun 16 13:35:03 EDT 2018


indygreg added a comment.


  So Python 3 is performing a lot more `read(-1)` calls than Python 2? That, uh, seems weird and might be worth investigating.
  
  Hiding the `read()` calls does undermine the tests somewhat. But it's not a deal breaker. Let's keep this commit and keep this excessive `read(-1)` issue in the back of our heads.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3733

To: durin42, pulkit, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list