D3665: graph: improve graph output by using Unicode characters

quark (Jun Wu) phabricator at mercurial-scm.org
Sat Jun 16 15:08:55 EDT 2018


quark added a comment.


  To be clear, I have no interest in +1 or -1 this feature, and I'm not interested in spending more time testing it. I think I have made it very clear that Windows (at least WSL) is going to be a headache. Not to say, Linux (as my primary OS) font rendering is another story that might surprise you.
  
  At a low-level, the Unicode specification does not define some characters to be "wide" or "narrow" explicitly. Using them is like "undefined behavior" depending on the actual font. `encoding._wide` cannot be accurate for two reasons - 1. no way to get the font details; 2. width is per character, not a global thing.
  
  I have seen people testing software on macOS only, then think it improves everyone's life and proudly announce the feature. As a Linux/Windows user, I feel sad.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3665

To: johnstiles, #hg-reviewers, spectral
Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel


More information about the Mercurial-devel mailing list