D3665: graph: improve graph output by using Unicode characters

quark (Jun Wu) phabricator at mercurial-scm.org
Sat Jun 16 15:42:50 EDT 2018


quark added a comment.


  Since you mentioned Linux... Here is what your extension renders on my Linux terminal:
  
  F103407: 2018-06-16-122437_1046x658_scrot.png <https://phab.mercurial-scm.org/F103407>
  
  The characters do not render as question marks, because I have fonts covering them and fontconfig smartly choose fallback fonts (Windows does similar things).
  
  I'm not saying others render the same as mine, but I'd repeat - "width" is per character, and is generally "undefined" - some of them are wide, some are narrow.
  
  You can say "it works great on *my* Linux", but not other's Linux. Depending on what fonts are installed, what the rendering engine is, what fontconfig says about font substitution rules, etc. There are just too many ways to get ugly results. And it still complies the Unicode standard - since it's undefined.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3665

To: johnstiles, #hg-reviewers, spectral
Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel


More information about the Mercurial-devel mailing list