D3757: rebase: add dry-run functionality

khanchi97 (Sushil khanchi) phabricator at mercurial-scm.org
Sun Jun 17 05:05:47 EDT 2018


khanchi97 added a comment.


  In https://phab.mercurial-scm.org/D3757#58993, @yuja wrote:
  
  > > +    dryrun = opts.get(r'dry_run')
  > >  +    if dryrun:
  > >  +        if opts.get(r'abort'):
  > >  +                raise error.Abort(_('cannot specify both --dry-run and --abort'))
  > >  +        if opts.get(r'continue'):
  > >  +                raise error.Abort(_('cannot specify both --dry-run and --continue'))
  >
  > Please remove the excessive 4 spaces before the "raise".
  
  
  Oh, sorry.
  
  > 
  > 
  >> +    if dryrun:
  >>  +        try:
  >>  +            overrides = {('rebase', 'singletransaction'): True}
  >>  +            with ui.configoverride(overrides, 'rebase'):
  >>  +                _origrebase(ui, repo, inmemory=True, dryrun=dryrun, **opts)
  > 
  > I meant the argument name `dryrun=` is misleading because it actually does
  >  rebase so `inmemory=True` and `_origrebase(ui, repo, abort=True)` are required.
  >  I think it's something like `leaveunfinished=`.
  
  Ah, right. I got it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3757

To: khanchi97, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list