D3756: rebase: no need to backup rebased csets while aborting
sushil khanchi
sushilkhanchi97 at gmail.com
Sun Jun 17 23:46:11 EDT 2018
okay, I think following the key rule of VCS would be better. Shall I update
the comment instead?
On Mon, Jun 18, 2018 at 8:50 AM, durin42 (Augie Fackler) <
phabricator at mercurial-scm.org> wrote:
> durin42 added a comment.
>
>
> In https://phab.mercurial-scm.org/D3756#58937, @indygreg wrote:
>
> > I'm unsure about this change. On one hand, the comment (which appears
> to have been added to mpm several years ago) implies that we never should
> have generated backups in this case. On the other, one of the key rules of
> a VCS is "don't eat my data." Even though we are aborting the operation, I
> could see some scenarios where someone would want a backup of the
> aborted/partially-completed rebase.
> >
> > @durin42: what do you think?
>
>
> I think the paranoia is probably better overall? Maybe update the
> comment?
>
> (I don't feel strongly.)
>
> REPOSITORY
> rHG Mercurial
>
> REVISION DETAIL
> https://phab.mercurial-scm.org/D3756
>
> To: khanchi97, #hg-reviewers
> Cc: indygreg, durin42, mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180618/336a906e/attachment.html>
More information about the Mercurial-devel
mailing list