[PATCH 6 of 9] byteify-strings: do not rewrite system string literals to u''

Pulkit Goyal 7895pulkit at gmail.com
Mon Jun 18 14:37:55 EDT 2018


On Mon, Jun 18, 2018 at 6:47 PM Yuya Nishihara <yuya at tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1527777875 -32400
> #      Thu May 31 23:44:35 2018 +0900
> # Node ID 5cdd7f14f888f265459ab94b79ae837d515a2ad8
> # Parent  e17f54b6889bceba8abbe7d4b9c450e66125a807
> byteify-strings: do not rewrite system string literals to u''
>
> It would make things worse on Python 2 because unicode processing is
> generally
> slower than byte string. We should just leave system strings unmodified.
>

​I think we can make this change to the transformer too.​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180619/3e9980b1/attachment.html>


More information about the Mercurial-devel mailing list