D3764: rebase: improve output of --dry-run

khanchi97 (Sushil khanchi) phabricator at mercurial-scm.org
Tue Jun 19 03:05:29 EDT 2018


khanchi97 added a comment.


  okay @pulkit , let me confirm if IIUC your points.
  
  1. First thing is we would have a function which will accept a `return_code`(0 or 1) and `output_data` (what can happen without --dry-run)  from any command (which has dry-run functionality). And will give output to the user according to the `return_code`. Following is the rough code for this, correct me if I am wrong at any point.
  
    def dryrunformatter(retcode, **outputdata):
        ui.status(_("starting dry-run; repository will not be changed"))
    
        # here show the outputdata accordingly
    
        if retcode == 0:
            ui.status(_("dry-run completed successfully; run without --dry-run/-n to perform this action"))
        else:
            ui.status(_("hit conflicts!"))
  
  
  
  2. If above explanation is right, talking about "additional functionality in dryrun" like --verbose mode in rebase which @indygreg suggested. May be we can add this type of functionality too in dryrunformatter? What do you say?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3764

To: khanchi97, #hg-reviewers
Cc: indygreg, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list