D3808: largefiles: use progress helper

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Jun 19 07:08:32 EDT 2018


pulkit accepted this revision.
pulkit added inline comments.

INLINE COMMENTS

> lfcommands.py:376
>      for hash in files:
> -        ui.progress(_('uploading largefiles'), at, unit=_('files'),
> -                    total=len(files))
> +        progress.update(at)
>          source = lfutil.findfile(rsrc, hash)

This one can also be progress.increment().

> lfutil.py:507
>      for i, n in enumerate(missing):
> -        repo.ui.progress(_('finding outgoing largefiles'), i,
> -            unit=_('revisions'), total=len(missing))
> +        progress.update(i)
>          parents = [p for p in repo[n].parents() if p != node.nullid]

This one too.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3808

To: martinvonz, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list