D3818: scmutil: make cleanupnodes optionally also fix the phase

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Wed Jun 20 12:29:44 EDT 2018


mharbison72 added a comment.


  I assume this was inspired at least in part by https://bz.mercurial-scm.org/show_bug.cgi?id=5918?
  
  When I was considering how to do this, I was thinking pass in an explicit phase to handle `hg amend --secret` and similar cases, and `None` if the phase should just be inherited from the old node(s).  Are there cases where nodes are replaced, but you don't want to change the phase at all?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3818

To: martinvonz, #hg-reviewers
Cc: mharbison72, yuja, mercurial-devel


More information about the Mercurial-devel mailing list