D3818: scmutil: make cleanupnodes optionally also fix the phase
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Jun 21 08:43:12 EDT 2018
yuja added a comment.
> > Not directly related to this patch. On API complexity: One of the unimplemented ideas is to require a transaction and make `operation` optional - default to the transaction name.
>
>
> Good idea. I like passing around the transaction explicitly.
+1. An explicit `tr` argument will make sure to wrap cleanupnodes() with
transaction.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3818
To: martinvonz, #hg-reviewers
Cc: quark, mharbison72, yuja, mercurial-devel
More information about the Mercurial-devel
mailing list