D3828: rebase: add **opts to _prepareabortorcontinue
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Fri Jun 22 10:18:20 EDT 2018
pulkit added inline comments.
INLINE COMMENTS
> rebase.py:328
>
> - def _prepareabortorcontinue(self, isabort):
> + def _prepareabortorcontinue(self, isabort, **opts):
> try:
As mentioned on IRC also, we should prevent using keyword arguments because in Python 3, we need to convert the keys to unicodes and then maybe back to bytes too. Can't we just pass this as a dictionary or add a new argument?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3828
To: khanchi97, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list