D3827: rebase: no need to store backup during dry-run while aborting

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Jun 25 08:14:40 EDT 2018


yuja added a comment.


  > - retcode = rbsrt._prepareabortorcontinue(abortf) +            # If in-memory, means aborting during dry-run, no need to backup +            backup = not rbsrt.inmemory +            retcode = rbsrt._prepareabortorcontinue(abortf, backup=backup)
  
  This seems confusing and is probably wrong since we wouldn't overwrite
  `inmemory` to `False` if in-memory rebase were resumable.
  
  I think explicit `backup` flag is less bad.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3827

To: khanchi97, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list