D2409: graft: add no-commit mode (issue5631)

[pulkit (Pulkit Goyal)]

pulkit added a comment.


  The patch mostly looks good to me. Added some minor nits. It will be great if you can add test where we graft multiple revs with --no-commit flag.

INLINE COMMENTS

> test-graft.t:1551
> +  $ hg ci -qAm2
> +  $ hg log
> +  changeset:   2:db815d6d32e6

We should print a graphical version of log so that test can be understand better. Maybe replace this with `hg log -GT "{rev}:{node|short} {desc}\n"`. Comment applies to other instances of `hg log` in test too.

> test-graft.t:1677
> +  grafting 4:a08bb3910e7c "4"
> +  $ hg tip -T "rev: {rev}\n"
> +  rev: 5

`hg log` will serve the purpose better here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2409

To: khanchi97, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel