D3849: rebase: refactor dryrun implementation

khanchi97 (Sushil khanchi) phabricator at mercurial-scm.org
Wed Jun 27 03:19:19 EDT 2018


khanchi97 added a subscriber: yuja.
khanchi97 added a comment.


  @yuja In this patch rebaseruntime is instantiated two times, one in _dryrunrebase and second in _origrebase, I don't know if it could make any problem although all tests are passing. Maybe _origrebase() also need some refactoring.
  See if this refactoring is good or if this can be improved, then please give some suggestions.
  Thanks :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3849

To: khanchi97, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list