D2568: lfs: convert hexdigest to bytes using sysbytes

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Mar 2 17:19:07 EST 2018


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> wrapper.py:89
>      # git-lfs only supports sha256
> -    oid = hashlib.sha256(text).hexdigest()
> +    oid = pycompat.sysbytes(hashlib.sha256(text).hexdigest())
>      self.opener.lfslocalblobstore.write(oid, text)

In other places, we've done `mercurial.node.hex(hashlib.sha256(text).digest())`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2568

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list