D2580: tests: fix various test-check-module-imports.t violations

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sat Mar 3 13:02:34 EST 2018


durin42 added inline comments.

INLINE COMMENTS

> pulkit wrote in test-i18n.t:58
> I am not sure why we need this but according to rest of the patch, these couple of imports should be in new lines.

The linter doesn't enforce that, so I didn't bother. Two imports felt short enough as to not explode it out into multiple lines.

The import checker does require that importing encoding or registrar has to come after importing _ from i18n.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2580

To: durin42, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list