D2068: revlog: do not use delta for lfs revisions

ryanmce (Ryan McElroy) phabricator at mercurial-scm.org
Sat Mar 3 15:21:02 EST 2018


ryanmce added inline comments.

INLINE COMMENTS

> quark wrote in revlog.py:2110
> `candelta` takes two revisions. Here there is only one revision. It's possible to pass a useless revision but that has unnecessary overhead.
> 
> `candelta` also fetches `flags`, here we already know the values `flags` so it's faster to avoid fetching it again.

Then why is this `REVIDX_KNOWN_FLAGS` and not `REVIDX_RAWTEXT_CHANGING_FLAGS`?

Given the number of questions here from me and others, I think the comment could use extension at least so future readers understand why this is the way it is.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2068

To: quark, indygreg, #hg-reviewers, ryanmce
Cc: mercurial-devel


More information about the Mercurial-devel mailing list