D2611: scmutil: avoid using basestring and add explicit handling of unicodes

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sun Mar 4 08:05:03 EST 2018


yuja added inline comments.

INLINE COMMENTS

> scmutil.py:191
> +        if isinstance(msg, type(u'')):
> +            msg = pycompat.sysbytes(msg)
> +        elif not isinstance(inst.args[1], bytes):

`msg` is unused

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2611

To: durin42, #hg-reviewers, indygreg
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list