D2593: state: add logic to parse the state file in old way if cbor fails
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Sun Mar 4 11:12:21 EST 2018
durin42 added inline comments.
INLINE COMMENTS
> pulkit wrote in state.py:84
> I am not confident about this part. Like to have some suggestions here.
Probably treat not-a-dict as corrupt and fall back to the other format?
> pulkit wrote in state.py:86
> Should I change thirdparty/cbor/ to raise specific errors?
Ugh. Yeah, maybe see if they'd take a patch upstream to raise a more explicit exception type.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2593
To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel
More information about the Mercurial-devel
mailing list