D2588: commit: adds multiline commit message support(issue5616)

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sun Mar 4 11:44:30 EST 2018


pulkit added inline comments.

INLINE COMMENTS

> fancyopts.py:365
>                      _('invalid value %r for option %s, %s') % (val, opt, s))
> -            state[name] = defmap[name].newstate(state[name], val, abort)
> +            if name == 'message':
> +                if state[name] != '':

I think this is not the right place to have this hack. We should have this as a part of `hg commit` code rather.

> test-commit.t:847
> +  files:       a
> +  description:
> +  This is the first line

starting with a newline seems awkward.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2588

To: sangeet259, #hg-reviewers
Cc: pulkit, jeffpc, mercurial-devel


More information about the Mercurial-devel mailing list