D2647: setdiscovery: include all local heads in second "known" request (issue5809)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sun Mar 4 14:44:49 EST 2018


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D2647#42980, @indygreg wrote:
  
  > The commit message looks incomplete?
  >
  > We really want a change like this to be documented. Could you please write more in the commit message and inline? The docstring of `_takequicksample()` is also now inaccurate.
  >
  > Also, I'm not convinced this change is correct. Should we connect IRL?
  
  
  Heh, I sent this by mistake. I think it should be functionally correct, but we can optimize better. I'll drop this patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2647

To: martinvonz, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list