[PATCH] lock: block signal interrupt while making a lock file

[Yuya Nishihara]

On Sun, 04 Mar 2018 14:31:30 -0500, Matt Harbison wrote:
> On Sun, 04 Mar 2018 14:18:04 -0500, Yuya Nishihara <yuya at tcha.org> wrote:
> 
> > On Sun, 04 Mar 2018 13:55:40 -0500, Matt Harbison wrote:
> >> On Sun, 04 Mar 2018 12:35:52 -0500, Kevin Bullock
> >> <kbullock+mercurial at ringworld.org> wrote:
> >>
> >> >> On Mar 4, 2018, at 11:48, Yuya Nishihara <yuya at tcha.org> wrote:
> >> >>
> >> >> # HG changeset patch
> >> >> # User Yuya Nishihara <yuya at tcha.org>
> >> >> # Date 1520138979 18000
> >> >> #      Sat Mar 03 23:49:39 2018 -0500
> >> >> # Node ID 8ff5f6277e204df49b3426a144375db11b41b38d
> >> >> # Parent  dad68a609114750b5963a8e46563a0b73620156f
> >> >> lock: block signal interrupt while making a lock file
> >> >
> >> > Seems okay, queued, thanks.
> >>
> >> Any chance of getting this on stable, so it can go into the next thg  
> >> build?
> >
> > I thought about that, but this patch seemed a bit scary for pushing into
> > stable.
> 
> Fair enough.  But maybe thg should include it somehow?  The problem is, I  
> haven't been able to build thg on Windows, and unlike on Linux, I have no  
> idea how to point it at a different version of hg.  So aside from testing  
> in core (and I've never hit the problem with bare hg.exe), I'm not sure  
> how much testing this will get before 4.6.0 anyway.

Perhaps the easiest way to test is to write an extension that replaces
util.makelock(). A stale lock file might still be left, but at least it
should contain a pid in it.