D2669: util: fix unsafe url abort with bytestr() on url

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sun Mar 4 16:44:19 EST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rHGca201470abb4: util: fix unsafe url abort with bytestr() on url (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2669?vs=6612&id=6621

REVISION DETAIL
  https://phab.mercurial-scm.org/D2669

AFFECTED FILES
  mercurial/util.py

CHANGE DETAILS

diff --git a/mercurial/util.py b/mercurial/util.py
--- a/mercurial/util.py
+++ b/mercurial/util.py
@@ -3097,7 +3097,7 @@
     path = urlreq.unquote(path)
     if path.startswith('ssh://-') or path.startswith('svn+ssh://-'):
         raise error.Abort(_('potentially unsafe url: %r') %
-                          (path,))
+                          (pycompat.bytestr(path),))
 
 def hidepassword(u):
     '''hide user credential in a url string'''



To: durin42, #hg-reviewers, pulkit
Cc: mercurial-devel


More information about the Mercurial-devel mailing list