D2624: perf: teach perfbdiff to call blocks() and to use xdiff

quark (Jun Wu) phabricator at mercurial-scm.org
Sun Mar 4 23:45:23 EST 2018


quark added inline comments.

INLINE COMMENTS

> perf.py:1024-1029
> +                if xdiff:
> +                    mdiff.bdiff.xdiffblocks(*pair)
> +                elif blocks:
> +                    mdiff.bdiff.blocks(*pair)
> +                else:
> +                    mdiff.textdiff(*pair)

Might move the assignment out of the loop:

                if xdiff:
                    f = mdiff.bdiff.xdiffblocks
                elif blocks:
                    f = mdiff.bdiff.blocks
                else:
                    f = mdiff.textdiff
  def d():
     ...
     f(*pairs)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2624

To: indygreg, #hg-reviewers, quark
Cc: mercurial-devel


More information about the Mercurial-devel mailing list