D2695: osutil: implement minimal __getitem__ compatibility on our custom listdir type

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Mar 5 19:02:08 EST 2018


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> osutil.c:130
> +	if (index != 8) {
> +		PyErr_Format(PyExc_TypeError, "osutil.stat objects only suport"
> +			     " stat.ST_MTIME in __getitem__");

I think this should be `PyExc_IndexError`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2695

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list