D2696: cleanup: use stat_result[stat.ST_MTIME] instead of stat_result.st_mtime
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Mon Mar 5 19:05:31 EST 2018
indygreg added inline comments.
INLINE COMMENTS
> osutil.c:125
> static PyObject *listdir_stat_getitem(PyObject *self, PyObject *key) {
> - long index = PyInt_AsLong(key);
> + long index = PyLong_AsLong(key);
> if (index == -1 && PyErr_Occurred()) {
Is this valid for Python 2? The passed argument will likely be a PyInt on Python 2. I thought `PyLong_AsLong` only operates on int types?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2696
To: durin42, #hg-reviewers
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list