D2701: merge: use constants for actions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Mar 6 11:53:05 EST 2018


indygreg marked an inline comment as done.
indygreg added a comment.


  In https://phab.mercurial-scm.org/D2701#43478, @phillco wrote:
  
  > btw, @quark mentioned there could be a perf hit (@sid0 mentioned this too a long time ago iirc)
  
  
  Are we sure about that? I could see a perf hit for dirstate. But I don't think merge things are in any critical paths. If you are performing a merge, you need to do working directory updates and/or read data from storage. I would expect these things to dwarf the time spent resolving Python variables to values.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2701

To: indygreg, #hg-reviewers, phillco
Cc: quark, sid0, phillco, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list