D2068: revlog: do not use delta for lfs revisions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Mar 6 13:03:42 EST 2018


indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> test-revlog-raw.py:156-161
> +        if r == 0 or rlog.flags(r):
>              text = rlog.revision(r, raw=True)
>              cachedelta = None
>          else:
> -            # deltaparent is more interesting if it has the EXTSTORED flag.
> -            deltaparent = max([0] + [p for p in range(r - 2) if rlog.flags(p)])
> +            # deltaparent cannot have EXTSTORED flag.
> +            deltaparent = max([-1] + [p for p in range(r) if not rlog.flags(p)])

I feel like this should be checking against specific flags. But since this is a test, I'm fine accepting this. We can fix in a follow-up if the logic is wrong.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2068

To: quark, indygreg, #hg-reviewers, ryanmce
Cc: mercurial-devel


More information about the Mercurial-devel mailing list