D2704: archival: fileit should not use atomictemp, causes major performance regression

vincent.parrett (Vincent Parrett) phabricator at mercurial-scm.org
Tue Mar 6 22:09:33 UTC 2018


vincent.parrett created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2704

AFFECTED FILES
  mercurial/archival.py

CHANGE DETAILS

diff --git a/mercurial/archival.py b/mercurial/archival.py
--- a/mercurial/archival.py
+++ b/mercurial/archival.py
@@ -267,7 +267,7 @@
         if islink:
             self.opener.symlink(data, name)
             return
-        f = self.opener(name, "w", atomictemp=True)
+        f = self.opener(name, "w", atomictemp=False)
         f.write(data)
         f.close()
         destfile = os.path.join(self.basedir, name)



To: vincent.parrett, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list