D2723: httppeer: remove _requestbuilder attribute

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Mar 8 05:31:25 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This was a glorified alias to a function in another module. I have no
  clue why it existed.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2723

AFFECTED FILES
  mercurial/httppeer.py

CHANGE DETAILS

diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py
--- a/mercurial/httppeer.py
+++ b/mercurial/httppeer.py
@@ -138,7 +138,6 @@
         self._path = path
         self._caps = None
         self._urlopener = None
-        self._requestbuilder = None
         u = util.url(path)
         if u.query or u.fragment:
             raise error.Abort(_('unsupported URL component: "%s"') %
@@ -151,7 +150,6 @@
         ui.debug('using %s\n' % self._url)
 
         self._urlopener = url.opener(ui, authinfo)
-        self._requestbuilder = urlreq.request
 
     def __del__(self):
         urlopener = getattr(self, '_urlopener', None)
@@ -328,7 +326,7 @@
         if varyheaders:
             headers[r'Vary'] = r','.join(varyheaders)
 
-        req = self._requestbuilder(pycompat.strurl(cu), data, headers)
+        req = urlreq.request(pycompat.strurl(cu), data, headers)
 
         if data is not None:
             self.ui.debug("sending %d bytes\n" % size)



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list