[PATCH] xdiff: fix trivial build warnings on Windows

Matt Harbison mharbison72 at gmail.com
Thu Mar 8 07:42:14 EST 2018


> On Mar 8, 2018, at 7:33 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> 
>> On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote:
>> Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc.
>> The git community has chosen to disallow diff >1GB files because of the
>> overflow concern [1].
>> 
>> [1]: https://github.com/git/git/commit/dcd1742e56ebb944c4ff62346da4548e1e3be675
> 
> So, should we queue this now or leave warnings to denote things that should
> be cleaned up?

I think the subsequent work that Jun did fixed a bunch of the warnings.  The only one that stood out last time I looked was the signed/unsigned comparison.  This can be dropped if Jun is still working on it.  I didn’t realize he was.



More information about the Mercurial-devel mailing list