D2747: hgweb: remove unused methods on wsgirequest
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Mar 9 02:27:56 UTC 2018
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
writelines() isn't used in our code base.
close() was a no-op. It is an optional method per PEP 0333.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2747
AFFECTED FILES
mercurial/hgweb/request.py
CHANGE DETAILS
diff --git a/mercurial/hgweb/request.py b/mercurial/hgweb/request.py
--- a/mercurial/hgweb/request.py
+++ b/mercurial/hgweb/request.py
@@ -306,16 +306,9 @@
if inst[0] != errno.ECONNRESET:
raise
- def writelines(self, lines):
- for line in lines:
- self.write(line)
-
def flush(self):
return None
- def close(self):
- return None
-
def wsgiapplication(app_maker):
'''For compatibility with old CGI scripts. A plain hgweb() or hgwebdir()
can and should now be used as a WSGI application.'''
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list