D2758: transaction: add a name and a __str__ implementation (API)

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Fri Mar 9 17:20:19 EST 2018


durin42 added a comment.


  Either way, you should make sure this always returns a sysstr, otherwise you'll cause pretty terrible python3 breakage. Look around for other __repr__ instances for examples.

INLINE COMMENTS

> transaction.py:191
>  
> +    def __str__(self):
> +        name = '/'.join(self.names)

nit: I think this would make more sense as a __repr__ than a __str__.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2758

To: martinvonz, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list