[PATCH 3 of 3] bdiff: convert more longs to int64_t

Matt Harbison mharbison72 at gmail.com
Fri Mar 9 22:07:03 EST 2018


# HG changeset patch
# User Matt Harbison <matt_harbison at yahoo.com>
# Date 1520650747 18000
#      Fri Mar 09 21:59:07 2018 -0500
# Node ID 09be2aeb8f5a364fab574ed3cf00bddbb7b9728a
# Parent  1f313a913f4356f272ef275061d5d169d9c1690e
bdiff: convert more longs to int64_t

MSVC previously flagged these where the function is stored in a pointer:

    bdiff.c(284) : warning C4028: formal parameter 1 different from declaration
    bdiff.c(284) : warning C4028: formal parameter 2 different from declaration
    bdiff.c(284) : warning C4028: formal parameter 3 different from declaration
    bdiff.c(284) : warning C4028: formal parameter 4 different from declaration

diff --git a/mercurial/cext/bdiff.c b/mercurial/cext/bdiff.c
--- a/mercurial/cext/bdiff.c
+++ b/mercurial/cext/bdiff.c
@@ -257,7 +257,8 @@
 	return NULL;
 }
 
-static int hunk_consumer(long a1, long a2, long b1, long b2, void *priv)
+static int hunk_consumer(int64_t a1, int64_t a2, int64_t b1, int64_t b2,
+                         void *priv)
 {
 	PyObject *rl = (PyObject *)priv;
 	PyObject *m = Py_BuildValue("llll", a1, a2, b1, b2);


More information about the Mercurial-devel mailing list