[PATCH] forget: add --dry-run mode

[Anton Shestakov]

On Sat, 10 Mar 2018 15:42:04 +0800
Anton Shestakov <av6 at dwimlabs.net> wrote:

> On Sat, 10 Mar 2018 12:46:41 +0530
> Sushil khanchi <sushilkhanchi97 at gmail.com> wrote:
> 
> > # HG changeset patch
> > # User Sushil khanchi <sushilkhanchi97 at gmail.com>
> > # Date 1520665399 -19800
> > #      Sat Mar 10 12:33:19 2018 +0530
> > # Node ID 430c6b5123ee72d3a209882495302e43b26cc988
> > # Parent  4c71a26a4009d88590c9ae3d64a5912fd556d82e
> > forget: add --dry-run mode
> > 
> > diff -r 4c71a26a4009 -r 430c6b5123ee mercurial/cmdutil.py
> > --- a/mercurial/cmdutil.py	Sun Mar 04 21:16:36 2018 -0500
> > +++ b/mercurial/cmdutil.py	Sat Mar 10 12:33:19 2018 +0530
> > @@ -1996,7 +1996,7 @@
> >          for subpath in ctx.substate:
> >              ctx.sub(subpath).addwebdirpath(serverpath, webconf)
> >  
> > -def forget(ui, repo, match, prefix, explicitonly):
> > +def forget(ui, repo, match, prefix, explicitonly, **opts):
> >      join = lambda f: os.path.join(prefix, f)
> >      bad = []
> >      badfn = lambda x, y: bad.append(x) or match.bad(x, y)
> > @@ -2039,9 +2039,10 @@
> >          if ui.verbose or not match.exact(f):
> >              ui.status(_('removing %s\n') % match.rel(f))
> >  
> > -    rejected = wctx.forget(forget, prefix)
> > -    bad.extend(f for f in rejected if f in match.files())
> > -    forgot.extend(f for f in forget if f not in rejected)
> > +    if not opts.get('dry_run'):
> 
> You want to add r to the string, similar to other code in cmdutil that
> handles opts.

Looks like only add() is doing this so far:
https://www.mercurial-scm.org/repo/hg/rev/a77e61b45384
But it still looks like you want r'' here.