D2718: wireproto: declare permissions requirements in @wireprotocommand (API)

[yuja (Yuya Nishihara)]

yuja added inline comments.

INLINE COMMENTS

> wireproto.py:711
> +    if permission not in ('push', 'pull'):
> +        raise error.Abort(_('invalid wire protocol permission; got %s; '
> +                            'expected "push" or "pull"') % permission)

Perhaps ProgrammingError is preferred here because it shouldn't
be a user-facing error.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2718

To: indygreg, #hg-reviewers, durin42
Cc: yuja, mercurial-devel