D2776: hgweb: use a multidict for holding query string parameters

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Mar 12 17:04:42 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> request.py:31
>  
> +class multidict(object):
> +    """A dict like object that can store multiple values for a key.

I'm a little uncomfortable with this not advertising that it's not a hash table, and htat lookups are O(N). Maybe send a docstring followup?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2776

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list