D2851: wireproto: define and implement protocol for issuing requests

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Mar 14 15:20:07 EDT 2018


indygreg planned changes to this revision.
indygreg added inline comments.

INLINE COMMENTS

> wireprotoframing.py:99-100
> +        offset = 0
> +        ARGUMENT_FRAME_HEADER.pack_into(payload, offset, len(k), len(v))
> +        payload[offset:offset + len(k)] = k
> +        offset += len(k)

We don't increment offset here. I have a fix for this locally. Will upload once I know someone starts looking at these commits, as I don't want to cause too much spam via resends.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2851

To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list