D2852: wireproto: implement basic frame reading and processing

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Mar 14 15:21:16 EDT 2018


indygreg abandoned this revision.
indygreg added inline comments.

INLINE COMMENTS

> wireprotoframing.py:81-87
> +def readframe(fh):
> +    """Read a unified framing protocol frame from a file object.
> +
> +    Returns a 3-tuple of (type, flags, payload) for the decoded frame or
> +    None if no frame is available. May raise if a malformed frame is
> +    seen.
> +    """

I have a minor refactor of this code locally so we can better support "sans I/O." Will send a new version once someone starts to look at this series.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2852

To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list