D2396: stack: import Evolve stack test file

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Mar 19 19:59:18 UTC 2018


indygreg accepted this revision.
indygreg added a subscriber: yuja.
indygreg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> revset.py:1534
>  
> + at predicate('stack([revs])', safe=True)
> +def _stack(repo, subset, x):

I'm not sure if the predicate should be prefixed with an underscore to mark it as internal. My reading of the help code is that the lack of a docstring will hide it from the docs.

I /think/ this is OK. But I wouldn't be surprised if @yuja or someone told me it needs changed. I'll queue this for now. We can always fix it up later if it is a problem.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2396

To: lothiraldan, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list